Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependent packages to the latest version #137

Merged
merged 8 commits into from
Apr 18, 2020
Merged

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Apr 18, 2020

This PR will upgrade dependent packages to the latest version via yarn upgrade --latest.

Notable changes

  • Upgrade Marp Core to v1.1.1 and Marp CLI to v0.17.4
    • No longer require to use the resolution field to fix reported vulnerabilities. 🙌
    • vsce package will get back to work and we can ship the updation of extension!
  • The latest yaml v1.9.0 has broken build through rollup: Duplicate export 'YAML'
    • We keep using v1.8.3 tentatively.
  • Puppeteer v3 for Marp CLI, to export into PDF/PPTX/images, is not compatible with older Node 10. We probably have to drop the support of some versions of VS Code using Electron 4. (Drop support for VS Code < 1.40 #138)

yhatt added 8 commits April 18, 2020 12:33
CommonJS build of yaml v1.9.0 throws error `Duplicate export 'YAML'`
while building via rollup.

yaml v1.9.0 has supported ES modules through "exports" field.
(eemeli/yaml#145) However, rollup bundler cannot
recognize it in any plugins.
(rollup/plugins#208)
Puppeteer in the bumped Marp CLI is not compatible with Node v10 using
in Electron 4.
Node 12.8.1 is using Electron 7 in VS Code >= 1.43.
Drop support for VS Code < 1.40
@yhatt yhatt merged commit 609550c into master Apr 18, 2020
@yhatt yhatt deleted the upgrade-dependencies branch April 18, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant