Add "Enable HTML" option to allow HTML in Marp slide preview #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works well but I might consider another way to be better tracking of settings. Current implementation is not adaptive for the change of Marp instance (e.g. Theme CSS). In terms of UX, it requires reload preview pane manually. I think the implementation of VS Code's official Markdown Language features extension would be helpful. |
|
It would be better to make new release a priority.
UPDATE: Improved internal logic to be simple in #17 . |
|
A better tracking of configurations will be implemented in #20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added "Enable HTML" option (
markdown.marp.enableHtml) to allow HTML elements in Marp slide preview. It works as same as--htmloption in Marp CLI.VS Code's default preview is always allowed HTML, but HTML in Marp preview is disabled by default for matching to Marp's behavior. This option is affected only to Marp preview.
Related to #10.