Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misdetection of front-matter in code block #18

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Fix misdetection of front-matter in code block #18

merged 3 commits into from
Mar 21, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Mar 19, 2019

When there was front-matter with marp: true in code block, Marp for VSCode would misdetect Markdown as Marp slide even if specified marp: false in the real front-matter.

---
marp: false
---

```markdown
---
marp: true
---
```

marp

We must update RegExp for correct front-matter detection.

@yhatt yhatt added the bug Something isn't working label Mar 19, 2019
@yhatt yhatt marked this pull request as ready for review March 21, 2019 01:50
@yhatt yhatt merged commit 429953e into master Mar 21, 2019
@yhatt yhatt deleted the fix-frontmatter-misdetection branch March 21, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yhatt