Get ready for workspace trust #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User setting is still available even if in the untrusted workspace. Using an inherited HTML setting may have potentially dangerous when showing Markdown preview in untrusted workspace, so we have to always prevent HTML whenever the workspace is not trusted.
|
We are going to merge into |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #194
Background
Based on a vulnerabled classic Marp, we always have importance to security.
Our core features like export and theme CSS support may read potentially dangerous to user. For example:
Markdown preview (provided by VS Code) has already a security layer, but extended features by Marp are not. We have not adopted a potentially dangerous feature even if wanted by several users (such as #123).
VS Code team is working for the trusted workspace, the security mechanism for preventing malicious workspace. Marp should follow it to save users from some maliciouses.
Behavior
If enabled trusted workspace
security.workspace.trust.enabled:markdown.marp.exportcommand will not work. Instead show a prompt for checking workspace trust setting to user.markdown.marp.themesconfiguration by the workspace will ignore, as same as VS Code's Markdown previewmarkdown.styles. But accept if configured as user setting.In the untrusted workspace,
markdown.marp.enableHtmlwill be recognized as alwaysfalse.In quick pick menu, the export command will mark by the shield icon.