New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong highlight in CRLF #240

Merged

yhatt merged 3 commits into main from directive-parser-crlf

May 18, 2021

Member

yhatt commented May 18, 2021

Fix #239.

The current YAML parser (yaml) removes CR in the normalize process. So we will use yaml@next (& normalize trailing CR of the passed text to prevent parse error)
HTML comment parser (rehype) returns the comment node with normalized value. To pass the raw text including CR into YAML parser, we have to pick substring from HTML sourcemap manually.

yhatt added 3 commits

May 19, 2021 03:29


          Add test case of parser for CR+LF newline

b9e5f58


          Fix YAML sourcemap with CR+LF

13a07da

By updating yaml package to v2 (next)


          [ci skip] Update CHANGELOG.md

d935fa2

yhatt merged commit 0e0e0ba into main

yhatt deleted the directive-parser-crlf branch

May 18, 2021 19:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet