Force to run Marp script before VS Code preview script #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes different approach from #251: Patch
MarkdownContentProvider.prototype.getScripts
to force running Marp's preview script before other scripts including VS Code preview.VS Code's Markdown extension has become able to patch because the engine has exposed to
env
object of markdown-it renderer since VS Code v1.57 (https://github.com/microsoft/vscode/blob/b0ae2854927c19e4de54edd3890ec681f96476e5/extensions/markdown-language-features/src/markdownEngine.ts#L166-L175). It is obviously a hack but removingasync
attribute from Marp<script>
is the most reliable way to prevent jumping scroll.Fix #248.