-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to export PDF, HTML, and images via Marp CLI integration #30
Conversation
Includes @marp-team/marp-cli v0.9.2.
import-name rule prefers using "export" as a function name, but it is reserved word in TS.
- Add link to download Chrome and Chromium - Hide description of Chromium in unsupported platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notable change about Node:
@@ -1 +1 @@ | |||
v10.2.0 | |||
v10.15.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v10.2.0 is an integrated Node with VS Code, but it raises error of fsevents
when running yarn watch
. So we updated Node version to the latest LTS.
A test environment in CI that is not required build keeps using v10.2.0.
Add description of export
Now marp-vscode is not only for preview but also for creation.
We're working on adding Marp CLI integration. In this PR, we added command
markdown.marp.export
to export Markdown into PDF, HTML, and images (only for first slide) without using external Marp CLI. It resolves #4.Marp for VS Code detects a state of file, and pass either of an original input file or temporally created file to Marp CLI. If the buffer is a draft state (unsaved or untitled document), we will try to create temporally file. Preferences of Marp CLI is generated from VS Code configurations.
It has many refactors so we have to work for filling tests.
ToDo