Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to export PDF, HTML, and images via Marp CLI integration #30

Merged
merged 13 commits into from
May 11, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented May 10, 2019

We're working on adding Marp CLI integration. In this PR, we added command markdown.marp.export to export Markdown into PDF, HTML, and images (only for first slide) without using external Marp CLI. It resolves #4.

export

Marp for VS Code detects a state of file, and pass either of an original input file or temporally created file to Marp CLI. If the buffer is a draft state (unsaved or untitled document), we will try to create temporally file. Preferences of Marp CLI is generated from VS Code configurations.

It has many refactors so we have to work for filling tests.

ToDo

  • Fill tests

Copy link
Member Author

@yhatt yhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable change about Node:

@@ -1 +1 @@
v10.2.0
v10.15.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v10.2.0 is an integrated Node with VS Code, but it raises error of fsevents when running yarn watch. So we updated Node version to the latest LTS.

A test environment in CI that is not required build keeps using v10.2.0.

@yhatt yhatt marked this pull request as ready for review May 11, 2019 17:10
yhatt added 3 commits May 12, 2019 03:02
Add description of export
Now marp-vscode is not only for preview but also for creation.
@yhatt yhatt merged commit 37f1a73 into master May 11, 2019
@yhatt yhatt deleted the marp-cli-integration branch May 11, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marp CLI integration to export PDF
1 participant