Improve initialization of preview styling in VS Code 1.63 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To wait synchronous execution of every preview scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upcoming VS Code 1.63, every scripts for Markdown preview, including Marp, will execute asynchronously. If our initialization script will run before the scripts provided by other extensions, the style removal for to avoid confliction will fail in styles inserted by the scripts.
This PR changes the preview script to call the initialization callback again when fired
window.onload. A delayed initialization callback inonloadcould wait synchronous execution of every scripts that have loaded asynchrnously.