Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the behavior of auto-scaling component in the preview #361

Merged
merged 4 commits into from
Jun 6, 2022

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jun 5, 2022

  • is attribute in VS Code's incremental DOM update has a different problem.
    • The node has to replace to upgrade into the custom element. setAttribute('is', 'marp-xxx') to the same node does not trigger of upgrade. VS Code's preview updation by morphdom is not handling this case.
    • ➡️ When brought incremental update of Markdown, Marp for VS Code will find out not-upgraded elements and replace the node into the custom element by assigning the same value of outerHTML by self. There are no effects to already processed nodes so it would bring less performance hit.

Fix #360.

@yhatt yhatt merged commit 4754b71 into main Jun 6, 2022
@yhatt yhatt deleted the patch-auto-scaling-in-preview branch June 6, 2022 13:20
@yhatt yhatt changed the title Fix the beahavior of auto-scaling component in the preview Fix the behavior of auto-scaling component in the preview Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] Auto-scaling is not working in the preview
1 participant