Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all: revert to reset injected CSS into the slide preview by other extensions #443

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Oct 28, 2023

Replaced to use all: revert instead of all: initial to reset injected styles into the slide preview by other extensions.

On inherited properties, the initial value may be unexpected. You should consider using the inherit, unset, revert, or revert-layer keywords instead.

https://developer.mozilla.org/en-US/docs/Web/CSS/initial

all: initial has been tainted many children CSS properties that allowed an inherited value. In fact, using some styles displays the unexpected result.

---
marp: true
---

# Hello, <span style="position: relative;">world</span>!

#442 (comment)

CSS Cascading and Inheritance Level 4 allows revert keyword, to reset them into UA default correctly.

Fix #442.

yhatt added 3 commits October 28, 2023 17:46
`all: initial` has been tainted many CSS properties for child elements,
that allowed an inherited value. CSS Cascading and Inheritance Level 4
allows `revert` keyword, to reset them into UA default correctly.
@yhatt yhatt merged commit f02b015 into main Oct 28, 2023
1 check passed
@yhatt yhatt deleted the fix-slide-view-disappeared-relative-element branch October 28, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't using Html label <sup> in Marp for VS code
1 participant