Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown.marp.chromePath preference to allow setting Chrome custom path #46

Merged
merged 5 commits into from
Jun 12, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jun 10, 2019

The added preference markdown.marp.chromePath can set the custom Chrome path to export PDF and image. If it's empty or not executable, Marp CLI would fallback to the installed Google Chrome.

For example, the user can swap the PDF export engine to Microsoft Edge Insider.

Extension Development Host  - Settings - Visual Studio Code - Insiders 2019_06_11 0_15_35

Resolves #44.

ToDo

  • Add unit test

@yhatt yhatt merged commit 04f63b2 into master Jun 12, 2019
@yhatt yhatt deleted the chrome-path branch June 12, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working, even though I have chrome.exe on my path
1 participant