Added setting to make env.openExternal optional
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of this getting merged? @yhatt |
|
@rtfmkiesel Merge upstream and please confirm to pass CI check. If not, please add tests. We can review after than. |
yhatt
reviewed
Jan 17, 2025
src/commands/export.ts
Outdated
Comment on lines
198
to
201
| if (outputToLocalFS) { | ||
| env.openExternal(uri) | ||
| if (shouldOpen) { | ||
| env.openExternal(uri) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (outputToLocalFS) { | |
| env.openExternal(uri) | |
| if (shouldOpen) { | |
| env.openExternal(uri) | |
| } | |
| if (outputToLocalFS && shouldOpen) { | |
| env.openExternal(uri) |
If the file is not opened automatically, I think it's better to run else clause to provide a feedback to the user about the completion of the export process.
yhatt
approved these changes
Jan 23, 2025
yhatt
added a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the auto-open functionality. Here is a setting, with the default being enabled (as it is now), which lets a user adjust this to their taste.