[v3] markdown.marp.html setting to control which HTML elements are rendered
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marp Core v4 has been allowed many HTML elements by default, and the new major version of Marp for VS Code is going to respect. However,
markdown.marp.enableHtmlshould set a boolean value so cannot set an intermediate state.Thus, we provide a new option
markdown.marp.htmlinsteadmarkdown.marp.enableHtml:off: HTML elements are completely disabled.default: Some allowlisted HTML elements by Marp Core are allowed. (=markdown.marp.enableHtml: false, default)all: All HTML elements are enabled. (=markdown.marp.enableHtml: true)In the untrusted workspace, HTML elements will be completely disabled for security.
Currently if
markdown.marp.enableHtmlhas been set astrue, we still recognize it and render all HTML elements as same as v2, but the deprecation warning will show. We will retain this behavior for a certain period to encourage users to update their settings.