Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] markdown.marp.browser and markdown.marp.browserPath settings #478

Merged
merged 10 commits into from
Dec 31, 2024

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Dec 31, 2024

Marp CLI v4 has been supported Firefox browser. To support Firefox browser in the next major version of Marp for VS Code, this PR adds markdown.marp.browser and markdown.marp.browserPath settings.

markdown.marp.browser

This option is coressponding to browser option of Marp CLI.

  • auto: Automatically detect Chrome, Chromium, Edge, or Firefox.
  • chrome: Use Google Chrome.
  • edge: Use Microsoft Edge.
  • firefox: Use Mozilla Firefox.

markdown.marp.browserPath

This option is to replace a legacy setting markdown.marp.chromePath. Set the custom browser path to export.

The kind of browser is specified by markdown.marp.browser. If it was auto, Marp for VS Code will detect the kind of browser automatically. Currently we simply detect if the binary name is including firefox or fx.

@yhatt yhatt merged commit 440f3ed into main Dec 31, 2024
1 check passed
@yhatt yhatt deleted the browser-path-setting branch December 31, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant