Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement observer to notify about incompatible extensions #488

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jan 16, 2025

This observer will detect if opened Marp document together with the Markdown preview that is not supported Marp, e.g. the Markdown Preview provided by Markdown Preview Enhanced extension.

If detected, Marp shows warning and provide an option to open with VS Code preview.

It is required for mitigating confusions such as:

yhatt added 3 commits January 8, 2025 05:04
This observer will detect if opened Marp document together with the
Markdown preview that is not supported Marp, e.g. the Markdown Preview
provided by Markdown Preview Enhanced extension. If detected, Marp shows
warning and provide an option to open with VS Code preview.
@yhatt yhatt marked this pull request as ready for review January 23, 2025 15:13
@yhatt yhatt changed the title Implement incompatible extensions observer Implement observer to notify about incompatible extensions Jan 23, 2025
@yhatt yhatt merged commit 1f00a32 into main Jan 23, 2025
1 check passed
@yhatt yhatt deleted the incompatible-extensions-observer branch January 23, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant