Migrate to @types/vscode package
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the release note from VS Code v1.36.0-insiders, now
vscodepackage has splitted into@types/vscode(by DefinetlyTyped) andvscode-test(for E2E test).By this change, Marp for VS Code has to use
@types/vscodeinstead ofvscodepackage. We are still keeping compatibillity with the least version v1.31.0, so we should keep minor version by using~1.31.0.vscode-testdoes not require to add because currently we have not E2E test. In future, we may be able to expect running E2E test with Jest, the standard testing library for marp-team because perhapsvscode-testpackage would become easy to maintain.