-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom theme support #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add markdown.marp.themes configuration that is following the spec of markdown.styles.
VS Code v1.37-insider allows `items` key for editing array-of-string settings with user-friendly editor.
CI was passed by filled unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39. I added
markdown.marp.themes
configuration property to specify paths for custom theme CSS. It has the same rule as VS code built-in configurationmarkdown.styles
: Specified paths must be URLs and relative paths from workspace directory.Marp requires the actual content of files unlike Markdown preview. Thus, we have to add the logic of resolving themes from URL or workspace/parent directory of Markdown to support Marp's custom theme in preview.
Resolving paths looks like difficult because we cannot access to the original document of VS Code in the context of markdown-it extension normally. But I found a trick that using
normalizeLink
method defined to markdown-it instance can resolve its workspace directory or parent directory. We use this trick to get same behavior ofmarkdown.styles
.Advantage of
markdown.marp.themes
is accepting external URL, very easy way to get community-driven CSS themes.ToDo