Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for VS Code < 1.36 #91

Merged
merged 8 commits into from
Nov 7, 2019
Merged

Drop support for VS Code < 1.36 #91

merged 8 commits into from
Nov 7, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Nov 7, 2019

Resolves #79.

  • VS Code >= 1.36 is using Electron >= 4. No longer required @marp-team/marpit-svg-polyfill to deal with glitched rendering (as same as WebKit) for the outdated VS Code.
    • Electron < 6 still has glitched rendering about <video> that can use by enabling HTML. It's an edge case and VS Code has a plan to update into the latest Electron (7 currently).
  • VS Code >= 1.32 can use CodeAction.isPreferred to fix warnings and errors via "Auto Fix..." command.

@yhatt yhatt merged commit 46f9f78 into master Nov 7, 2019
@yhatt yhatt deleted the require-vscode-1.36 branch November 7, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for VS Code < 1.36
1 participant