Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependent packages to the latest version #93

Merged
merged 4 commits into from
Nov 7, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Nov 7, 2019

This PR will upgrade dependent packages to the latest version via yarn upgrade --latest, excepted @types/vscode. It includes Marp Core v0.15.1 and Marp CLI v0.16.0 Marp CLI v0.16.1.

Notable changes

  • Since Marp Core v0.14.0, it injects inline helper script for browser context. However, VS Code preview pane will restrict execution of the unknown inline script. The script has already executed in preview.js so we have to set script: false to prevent injection.

@yhatt
Copy link
Member Author

yhatt commented Nov 7, 2019

import browserCjs from '@marp-team/marp-core/lib/browser.cjs'

Since Marp Core v0.14.0, the entry point for browser context was replaced into @marp-team/marp-core/browser.

import browser from '@marp-team/marp-core/browser'

However, the result (bundled through rollup-plugin-commonjs) is incorrect. It may be related to rollup/rollup-plugin-commonjs#414.

We can still use the same entrypoint (designed for internal usage) to avoid this issue.

@yhatt yhatt merged commit f0c45ee into master Nov 7, 2019
@yhatt yhatt deleted the update-dependencies branch November 7, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant