Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #99

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Update README.md #99

merged 3 commits into from
Nov 13, 2019

Conversation

eric-burel
Copy link
Contributor

Add a word about HTML preview activation.
Maybe we could add why it is disabled by default (for security reasons I guess?)

Closes #98

Add a word about HTML preview activation
Closes marp-team#98
@yhatt
Copy link
Member

yhatt commented Nov 12, 2019

Maybe we could add why it is disabled by default (for security reasons I guess?)

Yes, it would be better. Default preference should be keeping safe from script injections by untrusted Markdown.

@yhatt
Copy link
Member

yhatt commented Nov 13, 2019

Cool. Thanks you for contribution. 👍

@yhatt yhatt merged commit c74b349 into marp-team:master Nov 13, 2019
@isaacdevlugt
Copy link

I'd like to enable HTML code in Marp for VS Code. How do I do this? I'm not sure what is meant by "You can enable previsualization of HTML code within Marp Markdown with the markdown.marp.enableHtml option", as stated in the README.

@yhatt
Copy link
Member

yhatt commented Apr 14, 2020

@isaacdevlugt Marp team does not recommend to enable HTML, for saving average users like you from some malicious. Enabling HTML is for the advanced user, and especially should take care if you could not recognize a meaning.

You have to learn how to be setting in VS Code at https://code.visualstudio.com/docs/getstarted/settings#_creating-user-and-workspace-settings. To enable "Markdown > Marp: Enable HTML" in setting GUI means exactly same as enabling markdown.marp.enableHtml in setting by JSON.

Our docs won't explain about VS Code built-in features to avoid confusion about the feature of our extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation about how to enable HTML into README
3 participants