Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert enhanced plugin system #146

Merged
merged 3 commits into from
Apr 1, 2019
Merged

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Apr 1, 2019

This PR reverts #127. An enhanced plugin system is too complex and become to be difficult to implement extended features at inherited class. (marp-team/marp-core#64)

In addition, a main motivation of enhanced plugin system has been lost because a way to extend VS Code's markdown-it had changed in marp-team/marp-vscode#17.

We should keep a simple way to extend Marpit, is the same way as markdown-it plugin.

@yhatt yhatt merged commit 46712a1 into master Apr 1, 2019
@yhatt yhatt deleted the revert-enhanced-plugin-system branch April 1, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant