Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local directives about background images have an basic vulnerability of style injection. It can apply any style, and can access to unexpected remote URL by
url()
.We create
InlineStyle
helper class to sanitize unexpected declarations through PostCSS.In image filter syntax, we have already applied escaping passed filter arguments, but current way of escaping CSS is wrong. We have fixed to follow W3C CSS3 Escaping. e.g.:
\(
➡️\28
CSS.escape or its polyfill will too much escape chars, and it will break filter functions.