Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type definition about Theme.meta and Marpit's internal variables #58

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Aug 27, 2018

This PR will improve type definitions about Theme.meta and Marpit's internal variables. (mark as protected)

  • Theme class's meta property had not been an indexable types. We added it and add theme property definition too. It is always available whenever following this definition.

  • Add definition about frequently used internal variables in Marpit class. We marked these as protected for inherited class developer. User should not use these.

@yhatt yhatt merged commit 08cb5c9 into master Aug 27, 2018
@yhatt yhatt deleted the improve-type-definition branch August 27, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant