Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storage infos in web #2317

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Add storage infos in web #2317

merged 5 commits into from
Aug 11, 2021

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

Display storage infos in web

Related issue number

Fixes #2158

@hekaisheng hekaisheng added this to the v0.8.0a2 milestone Aug 10, 2021
@qinxuye qinxuye added the to be backported Indicate that the PR need to be backported to stable branch label Aug 10, 2021
@hekaisheng hekaisheng force-pushed the web/storage-info branch 2 times, most recently from e927964 to 7dadb3c Compare August 10, 2021 05:10
wjsi
wjsi requested changes Aug 10, 2021
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_node_disk_info not called. Pease also revert changes in package-lock.json and use npm>=7.0.0.

mars/services/storage/core.py Outdated Show resolved Hide resolved
wjsi
wjsi requested changes Aug 10, 2021
View reviewed changes
mars/services/storage/core.py Outdated Show resolved Hide resolved
mars/services/storage/core.py Outdated Show resolved Hide resolved
wjsi
wjsi approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 3e308f2 into mars-project:master Aug 11, 2021
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Aug 13, 2021
@hekaisheng
Add storage infos in web (mars-project#2317)
c4c9e82 
(cherry picked from commit 3e308f2)
@hekaisheng hekaisheng mentioned this pull request Aug 13, 2021
Merged
qinxuye pushed a commit that referenced this pull request Aug 13, 2021
@hekaisheng
[BACKPORT] Add storage infos in web (#2317) (#2333)
228e99e
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Aug 13, 2021
chaokunyang pushed a commit to chaokunyang/mars that referenced this pull request Aug 16, 2021
@hekaisheng @chaokunyang
Add storage infos in web (mars-project#2317)
cf4df36
@hekaisheng hekaisheng deleted the web/storage-info branch March 11, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: web type: feature New feature
Projects
None yet
Milestone
v0.8.0a2
Development

Successfully merging this pull request may close these issues.

Add summary info of storage in web
3 participants
@hekaisheng @qinxuye @wjsi