[Ray] Refine ray tests #2793
Merged
[Ray] Refine ray tests #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
changed the title
chaokunyang
force-pushed
the
use_pytest_forked_for_ray_test
branch
from
a2280c9 to
b155779
Compare
zhongchun
reviewed
Mar 8, 2022
chaokunyang
force-pushed
the
use_pytest_forked_for_ray_test
branch
from
e81fd84 to
11e1330
Compare
…_ray_test # Conflicts: # mars/oscar/backends/ray/pool.py
qinxuye
added
mod: ray integration
to be backported
wjsi
reviewed
Mar 8, 2022
|
Codacy failed, please fix it. |
chaokunyang
force-pushed
the
use_pytest_forked_for_ray_test
branch
from
7821cc8 to
df7185f
Compare
chaokunyang
force-pushed
the
use_pytest_forked_for_ray_test
branch
from
4304efd to
b38232e
Compare
wjsi
reviewed
Mar 9, 2022
ci/reload-env.sh
Outdated
| @@ -1,5 +1,6 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
| set -x | |||
There was a problem hiding this comment.
Github actions put set -e as a default option. set -x will add unnecessary call records and should be used for debug purpose only.
There was a problem hiding this comment.
set -x can help us locate bugs, I prefer enable it. For CI, I think it's OK to have more logs to keep as much info as possible. Is there any privacy issue for enable it?
There was a problem hiding this comment.
When using if block in bash, option -e will output EVERY statement executed. Thus it is not appropriate to enable this globally. I'll remove it myself.
wjsi
reviewed
Mar 9, 2022
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Mar 11, 2022
wjsi
added a commit
that referenced
this pull request
Mar 11, 2022
qinxuye
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
refine ray tests:
Related issue number
Fixes #2792
Check code requirements