Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dirty version when building with CIBW #2855

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Fix dirty version when building with CIBW #2855

merged 1 commit into from
Mar 22, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Mar 22, 2022

What do these changes do?

Fix dirty version when building with CIBW. We need to make sure branches are clean before every build.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: bug Something isn't working mod: deploy labels Mar 22, 2022
@wjsi wjsi added this to the v0.9.0rc1 milestone Mar 22, 2022
@wjsi wjsi requested review from qinxuye and hekaisheng as code owners March 22, 2022 16:17
@wjsi wjsi force-pushed the deploy/cibw_versioneer branch from e1e1c2a to d182ca1 Compare March 22, 2022 16:31
qinxuye
qinxuye approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 96af4fa into mars-project:master Mar 22, 2022
@wjsi wjsi deleted the deploy/cibw_versioneer branch March 23, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
mod: deploy type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng