Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove should_be_monotonic property #2949

Merged
merged 3 commits into from
Apr 24, 2022

Conversation

hekaisheng
Copy link
Contributor

@hekaisheng hekaisheng commented Apr 22, 2022

What do these changes do?

Remove should_be_monotonic property in IndexValue, it may cause incompatible results for some operands.

Related issue number

Fixes #2939

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng marked this pull request as ready for review April 22, 2022 09:28
@hekaisheng hekaisheng requested review from wjsi and qinxuye as code owners April 22, 2022 09:28
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 21b1c1a into mars-project:master Apr 24, 2022
@qinxuye qinxuye deleted the enh/remove_should_be_monotonic branch May 20, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove should_be_monotonic property in IndexValue
3 participants