Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dask.persist #2953

Merged
merged 3 commits into from
Apr 24, 2022
Merged

Add support for dask.persist #2953

merged 3 commits into from
Apr 24, 2022

Conversation

loopyme
Copy link
Contributor

@loopyme loopyme commented Apr 22, 2022

What do these changes do?

Add support for dask.persist

Related issue number

Fixes #2930

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch dask-on-mars labels Apr 22, 2022
@qinxuye qinxuye added this to the v0.9.0rc3 milestone Apr 22, 2022
@loopyme loopyme marked this pull request as ready for review April 23, 2022 07:40
@loopyme loopyme requested review from hekaisheng and wjsi as code owners April 23, 2022 07:40
qinxuye
qinxuye approved these changes Apr 23, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit adb4161 into mars-project:master Apr 24, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request May 5, 2022
@loopyme
Add support for dask.persist (mars-project#2953)
68ba112 
(cherry picked from commit adb4161)
@qinxuye qinxuye mentioned this pull request May 5, 2022
Merged
wjsi pushed a commit that referenced this pull request May 5, 2022
[BACKPORT] Add support for dask.persist (#2953) (#2990)
0918713
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

@wjsi wjsi Awaiting requested review from wjsi

Assignees
No one assigned
Labels
backported already PR has been backported dask-on-mars type: enhancement request
Projects
None yet
Milestone
v0.9.0rc3
Development

Successfully merging this pull request may close these issues.

[BUG] dask.persist cannot work on dask-on-mars
4 participants
@loopyme @qinxuye @hekaisheng @wjsi