Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development documents for metrics #2955

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

zhongchun
Copy link
Contributor

What do these changes do?

Add metrics docs including:

  • How to use metrics
  • Metrics backend
  • Metrics naming convention

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye
Copy link
Collaborator

qinxuye commented Apr 24, 2022

@zhongchun
Copy link
Contributor Author

Refer this doc: https://docs.pymars.org/zh_CN/latest/development/contributing.html#building-documentations to add translation.

Ok, thanks for you reminder.

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 260c315 into mars-project:master Apr 24, 2022
@qinxuye qinxuye changed the title Add metrics docs Add development documents for metrics Apr 24, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Apr 25, 2022
* Add metrics docs

* Add metrics chinese docs
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Apr 25, 2022
* Add metrics docs

* Add metrics chinese docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants