Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tell when remove mapper data after execution #3027

Merged
merged 3 commits into from
May 13, 2022
Merged

Use tell when remove mapper data after execution #3027

merged 3 commits into from
May 13, 2022

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

Use tell when remove mapper data after execution to reduce time cost.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: enhancement request to be backported Indicate that the PR need to be backported to stable branch mod: service labels May 12, 2022
@hekaisheng hekaisheng added this to the v0.10.0a1 milestone May 12, 2022
@hekaisheng hekaisheng requested review from qinxuye and wjsi as code owners May 12, 2022 10:51
@hekaisheng hekaisheng force-pushed the enh/remove-mapper-data branch from c8c00aa to 258c7dd Compare May 13, 2022 02:44
qinxuye
qinxuye approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 9c4cf2a into mars-project:master May 13, 2022
@hekaisheng hekaisheng deleted the enh/remove-mapper-data branch May 13, 2022 06:00
hekaisheng added a commit to hekaisheng/mars that referenced this pull request May 24, 2022
@hekaisheng
Use tell when remove mapper data after execution (mars-project#3027)
06005ea 
(cherry picked from commit 9c4cf2a)
@hekaisheng hekaisheng mentioned this pull request May 24, 2022
Merged
wjsi pushed a commit that referenced this pull request May 24, 2022
@hekaisheng
[BACKPORT] Use tell when remove mapper data after execution (#3027) (#…
f586587 
…3073)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: scheduling service type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@hekaisheng @qinxuye @wjsi