Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change code owners to Mars PMC maintainers #3031

Merged
merged 1 commit into from
May 13, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented May 13, 2022

What do these changes do?

This PR changed code owners to Mars PMC maintainers.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added this to the v0.10.0a1 milestone May 13, 2022
@qinxuye qinxuye requested review from wjsi and hekaisheng as code owners May 13, 2022 03:57
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
Copy link
Collaborator Author

qinxuye commented May 13, 2022

This PR did not touch code modification, thus skip CI.

Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi
Copy link
Member

wjsi commented May 13, 2022

For specific modules, code owners can act as a mechanism for notification. Thus it might not be appropriate to remove all owners.

@wjsi wjsi merged commit be82602 into mars-project:master May 13, 2022
@qinxuye qinxuye deleted the codeowners branch May 13, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants