[Ray] Implements get_total_n_cpu for Ray execution context #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrestone
changed the title
chaokunyang
reviewed
May 23, 2022
mars/services/task/execution/ray/tests/test_ray_execution_backend.py
Outdated
Show resolved
Hide resolved
chaokunyang
reviewed
May 23, 2022
| @implements(Context.get_total_n_cpu) | ||
| def get_total_n_cpu(self) -> int: | ||
| # TODO(fyrestone): Support auto scaling. | ||
| return self._config.get_n_cpu() * self._config.get_n_worker() |
There was a problem hiding this comment.
- What happed if
n_cpuandn_workernot configured into ray config? - Seems no case cover this
There was a problem hiding this comment.
Why mars doesn't need to implement get_total_n_cpu?
There was a problem hiding this comment.
- What happed if
n_cpuandn_workernot configured into ray config?- Seems no case cover this
The n_cpu and n_worker will be set when starting local cluster: https://github.com/mars-project/mars/blob/master/mars/deploy/oscar/local.py#L162. If these fields are not set, there should be a bug.
Mars backend has implemented the get_total_n_cpu API: https://github.com/mars-project/mars/blob/master/mars/services/context.py#L113
wjsi
added
to be backported
wjsi
pushed a commit
that referenced
this pull request
Jun 1, 2022
…3059) (#3104) Co-authored-by: Liu Bao <[email protected]>
wjsi
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
get_total_n_cpufor Ray execution context.Related issue number
#2893
Check code requirements