Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify DataFrameGroupByAgg's tile logic for auto method #3084

Merged
merged 1 commit into from
May 25, 2022

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

In #3051, we introduce a new tile strategy for DataFrameGroupByAgg if method is "auto" , it only works for cluster mode. However, it also brings improvements when executing on local, so we remove branch for local and unify them in this PR.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: enhancement request mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels May 25, 2022
@hekaisheng hekaisheng added this to the v0.10.0a1 milestone May 25, 2022
@hekaisheng hekaisheng requested a review from a team as a code owner May 25, 2022 04:06
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit 67d392b into mars-project:master May 25, 2022
@qinxuye qinxuye deleted the enh/unified-groupby-agg branch May 25, 2022 08:09
qinxuye pushed a commit to qinxuye/mars that referenced this pull request May 28, 2022
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants