Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call immutable web API only once when previous call blocks #3085

Merged
merged 3 commits into from
May 26, 2022
Merged

Call immutable web API only once when previous call blocks #3085

merged 3 commits into from
May 26, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented May 25, 2022

What do these changes do?

Call immutable web API only once when previous call does not return. This reduces potential call flood for services.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: enhancement request mod: web to be backported Indicate that the PR need to be backported to stable branch labels May 25, 2022
@wjsi wjsi added this to the v0.10.0a1 milestone May 25, 2022
@wjsi wjsi requested a review from a team as a code owner May 25, 2022 04:22
@wjsi wjsi force-pushed the enh/cache_blocking branch from 7f7e1e7 to 4ea9c34 Compare May 25, 2022 04:31
@wjsi wjsi force-pushed the enh/cache_blocking branch from 4ea9c34 to 7f8ec5a Compare May 25, 2022 04:31
@wjsi wjsi force-pushed the enh/cache_blocking branch from c697dc9 to c73f722 Compare May 25, 2022 06:34
qinxuye
qinxuye approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 992c077 into mars-project:master May 26, 2022
@wjsi wjsi deleted the enh/cache_blocking branch May 26, 2022 02:42
wjsi added a commit to wjsi/mars that referenced this pull request May 26, 2022
@wjsi
Call immutable web API only once when previous call blocks (mars-proj…
3c1a9b0 
…ect#3085)
@wjsi wjsi mentioned this pull request May 26, 2022
Merged
wjsi added a commit that referenced this pull request May 27, 2022
@wjsi
[BACKPORT] Call immutable web API only once when previous call blocks (…
b0f06be 
…#3085) (#3088)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: web type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng