Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT] [Metric] Fix prometheus metric backend (#3124) #3127

Merged
merged 1 commit into from
Jun 9, 2022
Merged

[BACKPORT] [Metric] Fix prometheus metric backend (#3124) #3127

merged 1 commit into from
Jun 9, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Jun 9, 2022

Backport of #3124 .

@qinxuye qinxuye added type: bug Something isn't working backport PR backported from pre-release branch to stable branch mod: metric labels Jun 9, 2022
@qinxuye qinxuye added this to the v0.9.0 milestone Jun 9, 2022
@qinxuye qinxuye requested review from hekaisheng and wjsi as code owners June 9, 2022 05:05
wjsi
wjsi approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit f66d470 into mars-project:v0.9 Jun 9, 2022
@qinxuye qinxuye deleted the bp/3124 branch June 9, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi approved these changes

@hekaisheng hekaisheng Awaiting requested review from hekaisheng hekaisheng is a code owner

Assignees
No one assigned
Labels
backport PR backported from pre-release branch to stable branch mod: metric type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qinxuye @wjsi @zhongchun