Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine UT and logs #3204

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Refine UT and logs #3204

merged 7 commits into from
Aug 9, 2022

Conversation

fyrestone
Copy link
Contributor

What do these changes do?

  • Some UTs need specific version of third party lib, e.g. ray.
  • Some logs may be too long.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@fyrestone fyrestone self-assigned this Jul 28, 2022
刘宝 and others added 3 commits July 28, 2022 17:06
@fyrestone fyrestone marked this pull request as ready for review August 1, 2022 07:58
@fyrestone fyrestone requested a review from a team as a code owner August 1, 2022 07:58
zhongchun
zhongchun previously approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

chaokunyang
chaokunyang approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qinxuye
qinxuye approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fyrestone fyrestone merged commit bfb6e73 into mars-project:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi left review comments

@qinxuye qinxuye qinxuye approved these changes

@chaokunyang chaokunyang chaokunyang approved these changes

@zhongchun zhongchun zhongchun left review comments

Assignees

@fyrestone fyrestone

Labels
type: enhancement request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fyrestone @qinxuye @zhongchun @wjsi @chaokunyang