[Metrics] Fix metrics and docs #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix ray storage metrics * Add valid check for metrics * Fix mars usage demo
chaokunyang
reviewed
Sep 5, 2022
chaokunyang
reviewed
Sep 5, 2022
Co-authored-by: Shawn <[email protected]>
Co-authored-by: Shawn <[email protected]>
chaokunyang
reviewed
Sep 7, 2022
mars/core/operand/core.py
Outdated
| @@ -490,7 +488,18 @@ def execute(results: Dict[str, Any], op: OperandType): | |||
| try: | |||
| result = executor(results, op) | |||
| succeeded = True | |||
| op_executed_number.record(1, {"op": op.__class__.__name__}) | |||
| global op_executed_number | |||
There was a problem hiding this comment.
This seems not easy to use compared to previsous API
There was a problem hiding this comment.
Can we update the metrics Counter/Guage instance when metris are init?
There was a problem hiding this comment.
Can we update the metrics Counter/Guage instance when metris are init?
Yes, good idea. I'll fix it.
…s into fix-metrics-initialization
zhongchun
force-pushed
the
fix-metrics-initialization
branch
from
c25eb91 to
73acfe9
Compare
2 tasks
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Sep 22, 2022
* Fix metrics and docs * Fix ray storage metrics * Add valid check for metrics * Fix mars usage demo * Fix metrics check * Remove unused log * Update mars/metrics/api.py Co-authored-by: Shawn <[email protected]> * Update mars/metrics/api.py Co-authored-by: Shawn <[email protected]> * Support lazy initialize metrics * Restore op_executed_number * Fix log Co-authored-by: buhe <[email protected]> Co-authored-by: Shawn <[email protected]> (cherry picked from commit 6c6fc48)
UranusSeven
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Sep 22, 2022
* Fix metrics and docs * Fix ray storage metrics * Add valid check for metrics * Fix mars usage demo * Fix metrics check * Remove unused log * Update mars/metrics/api.py Co-authored-by: Shawn <[email protected]> * Update mars/metrics/api.py Co-authored-by: Shawn <[email protected]> * Support lazy initialize metrics * Restore op_executed_number * Fix log Co-authored-by: buhe <[email protected]> Co-authored-by: Shawn <[email protected]> (cherry picked from commit 6c6fc48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In the previous design, metrics are allowed to be used without initialization. In this case, the default metrics, namely console metrics, are used, but this may lead to wrong use. For example, using metrics before initializing metrics, then using the default console metrics, but we may think that we have initialized metrics with prometheus or ray, then it should be the corresponding metrics. So this pr:
init_metricsRelated issue number
Fixes #xxxx
Check code requirements