TypeDispatcher support one type multiple serializers #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrestone
changed the title
added 4 commits
September 5, 2022 10:57
aresnow1
pushed a commit
to aresnow1/mars
that referenced
this pull request
Sep 7, 2022
* Dispatcher support multiple serializers to one type * Remove register_ray_serializers, unregister_ray_serializers * Add UT * Fix * Fix * Fix lint * Improve test coverage * Fix * Fix Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 5604cea)
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Sep 22, 2022
* Dispatcher support multiple serializers to one type * Remove register_ray_serializers, unregister_ray_serializers * Add UT * Fix * Fix * Fix lint * Improve test coverage * Fix * Fix Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 5604cea)
UranusSeven
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Sep 22, 2022
* Dispatcher support multiple serializers to one type * Remove register_ray_serializers, unregister_ray_serializers * Add UT * Fix * Fix * Fix lint * Improve test coverage * Fix * Fix Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 5604cea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Mars serializers are not compatible with Ray serializers because Ray needs to dispatch
ActorHandleandObjectRefto Ray's serializer for reference counting. But, someActorHandleandObjectRefare nested in objects, then we needs to register object type to RaySerializer which is not compatible with Mars object type serializer.This PR allows Mars to register multile serializers to one type, then Ray serializers are compatible with Mars serializers. We don't needs to
register_ray_serializersandunregister_ray_serializers.Related issue number
Fixes #xxxx
Check code requirements