-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray] Optimize ray executor submit subtask #3271
Merged
chaokunyang
merged 15 commits into
mars-project:master
from
fyrestone:optimize_ray_executor_submit_subtask
Oct 11, 2022
Merged
[Ray] Optimize ray executor submit subtask #3271
chaokunyang
merged 15 commits into
mars-project:master
from
fyrestone:optimize_ray_executor_submit_subtask
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinxuye
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chaokunyang
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Oct 13, 2022
* Optimize Ray executor submit subtask * Pin pandas<1.5.0 * Try to fix CI * Try to fix CI * Print stderr of asv benchmark * Fix * Fix Ray executor track bug * Fix * Fix * Fix * Remove asv benchmark * Improve coverage * Refine comments * Improve coverage Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 6e2f7c9)
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Oct 13, 2022
* Optimize Ray executor submit subtask * Pin pandas<1.5.0 * Try to fix CI * Try to fix CI * Print stderr of asv benchmark * Fix * Fix Ray executor track bug * Fix * Fix * Fix * Remove asv benchmark * Improve coverage * Refine comments * Improve coverage Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 6e2f7c9)
aresnow1
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Oct 13, 2022
* Optimize Ray executor submit subtask * Pin pandas<1.5.0 * Try to fix CI * Try to fix CI * Print stderr of asv benchmark * Fix * Fix Ray executor track bug * Fix * Fix * Fix * Remove asv benchmark * Improve coverage * Refine comments * Improve coverage Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 6e2f7c9)
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Oct 24, 2022
* Optimize Ray executor submit subtask * Pin pandas<1.5.0 * Try to fix CI * Try to fix CI * Print stderr of asv benchmark * Fix * Fix Ray executor track bug * Fix * Fix * Fix * Remove asv benchmark * Improve coverage * Refine comments * Improve coverage Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit 6e2f7c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
There is a set intersection logic in Ray executor to determine whether the subtask result chunks are the stage results. It could be very slow when the stage has too many chunks and subtasks, e.g. a stage with 100000 result chunks and 50000 subtasks. This PR reuses the info generated in constructing a subtask to avoid set intersecion.
Also, Fix Ray executor track bug.
Test code
This case submit 50000 subtasks in a stage.
Related issue number
Fixes #xxxx
Check code requirements