Fix s3 client kwargs #3316
Merged
Fix s3 client kwargs #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 10, 2023 11:27
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Jan 16, 2023
* Fix s3 client kwargs * Add type annotation * Fix UT * Fix UT Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit aa1b261)
ChengjieLi28
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Jan 17, 2023
* Fix s3 client kwargs * Add type annotation * Fix UT * Fix UT Co-authored-by: 刘宝 <[email protected]> (cherry picked from commit aa1b261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix "client_kwargs" not works for s3 storage options.
Related issue number
Fixes #xxxx
Check code requirements