Fix typing for class_registry.get_class (#2735)

* Fix typing for class_registry.get_class * Update changelog
marshmallow-code · Jan 7, 2025 · 0902941 · 0902941
1 parent 9136ff9
commit 0902941
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,6 +1,13 @@
 Changelog
 ---------
 
+3.24.1 (unreleased)
+*******************
+
+Bug fixes:
+
+- Typing: Fix typing for `class_registry.get_class <marshmallow.class_registry.get_class>` (:pr:`2735`).
+
 3.24.0 (2025-01-06)
 *******************
 

diff --git a/src/marshmallow/class_registry.py b/src/marshmallow/class_registry.py
@@ -70,12 +70,12 @@ class MyClass:
 
 
 @typing.overload
-def get_class(classname: str, all: typing.Literal[False]) -> SchemaType: ...
+def get_class(classname: str, all: typing.Literal[False] = ...) -> SchemaType: ...
 
 
 @typing.overload
 def get_class(
-    classname: str, all: typing.Literal[True]
+    classname: str, all: typing.Literal[True] = ...
 ) -> list[SchemaType] | SchemaType: ...
 
 

diff --git a/tests/mypy_test_cases/test_class_registry.py b/tests/mypy_test_cases/test_class_registry.py
@@ -0,0 +1,4 @@
+from marshmallow import class_registry
+
+# Works without passing `all`
+class_registry.get_class("MySchema")