Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forked s3-plugin #1

Merged
merged 10 commits into from
Nov 5, 2015
11 changes: 6 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<artifactId>s3</artifactId>
<packaging>hpi</packaging>
<version>0.8-SNAPSHOT</version>
<version>0.9-SNAPSHOT</version>
<name>Jenkins S3 publisher plugin</name>
<url>https://wiki.jenkins-ci.org/display/JENKINS/S3+Plugin</url>

Expand Down Expand Up @@ -43,13 +43,14 @@
<connection>scm:git:ssh://github.com/jenkinsci/s3-plugin.git</connection>
<developerConnection>scm:git:ssh://[email protected]/jenkinsci/s3-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/s3-plugin</url>
</scm>
<tag>HEAD</tag>
</scm>

<dependencies>
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk</artifactId>
<version>1.9.6</version>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>aws-java-sdk</artifactId>
<version>1.10.16</version>
</dependency>
<dependency>
<groupId>net.java.dev.jna</groupId>
Expand Down
17 changes: 11 additions & 6 deletions src/main/java/hudson/plugins/s3/Destination.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,25 @@ public Destination(final String userBucketName, final String fileName) {
throw new IllegalArgumentException("Not defined for null parameters: "+userBucketName+","+fileName);

final String[] bucketNameArray = userBucketName.split("/", 2);
final String s3CompatibleFileName = replaceWindowsBackslashes(fileName);

bucketName = bucketNameArray[0];

if (bucketNameArray.length > 1) {
objectName = bucketNameArray[1] + "/" + fileName;
objectName = bucketNameArray[1] + "/" + s3CompatibleFileName;
} else {
objectName = fileName;
objectName = s3CompatibleFileName;
}
}

@Override
public String toString() {
return "Destination [bucketName="+bucketName+", objectName="+objectName+"]";
}
private String replaceWindowsBackslashes(String fileName) {
return fileName.replace("\\", "/");
}

@Override
public String toString() {
return "Destination [bucketName="+bucketName+", objectName="+objectName+"]";
}


public static Destination newFromRun(Run run, String bucketName, String fileName)
Expand Down
6 changes: 6 additions & 0 deletions src/test/java/hudson/plugins/s3/BucketnameTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,10 @@ public void testAnythingAfterSlashInBucketNameIsPrependedToObjectName() {

}

@Test
public void testWindowsPathsConvertingToS3CompatiblePaths() {
assertEquals("Destination [bucketName=my-bucket, objectName=with-some/subfolder//path-from/windows.txt]",
new Destination("my-bucket/with-some/subfolder/", "path-from\\windows.txt").toString() );
}

}