Report when exceptions are hit to CDT #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
martijnthe
reviewed
Apr 9, 2018
| @@ -186,7 +186,7 @@ export class ChromeDevToolsProxyServer { | |||
| * Sends Debugger.paused event for the current debugger location | |||
| */ | |||
| sendPaused(breakpoint: Breakpoint | undefined, backtrace: Array<Breakpoint>, | |||
| reason: 'exception' | 'debugCommand' | 'other') { | |||
| reason: 'exception' | 'debugCommand' | 'other', exception?: string) { | |||
There was a problem hiding this comment.
I know it was here already but it's started to draw attention to itself now :)
Maybe create a type for the reason close to the place where the sendPaused delegate contract is declared to avoid this long local type here?
type PausedReason = 'exception' | 'debugCommand' | 'other';
and then here:
reason: PausedReason
There was a problem hiding this comment.
This isn't really a delegate call but an API... the controller calls this. I'm assuming it's still a good idea.
JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]