Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix GH 1Password config (again) #84

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: Fix GH 1Password config (again) #84

merged 1 commit into from
Jan 21, 2025

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Jan 21, 2025

Summary by Sourcery

Bug Fixes:

  • Fix an issue where 1Password configuration was not set up correctly.

- last change didn't fix it
Copy link

trunk-io bot commented Jan 21, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request fixes the 1Password configuration by setting the correct permissions for the 1Password configuration directory and plugins directory.

Sequence diagram for 1Password config permissions fix

sequenceDiagram
    participant S as Setup Script
    participant FS as File System
    S->>FS: Copy files to home directory
    S->>FS: Set ~/.config/op permissions to 700
    S->>FS: Set ~/.config/op/plugins/used_items permissions to 700
Loading

File-Level Changes

Change Details Files
Set the correct permissions for the 1Password configuration directory and plugins directory.
  • Added a command to set the permissions of the 1Password configuration directory to 700.
  • Added a command to set the permissions of the 1Password plugins directory to 700.
local.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider providing more detail in the commit message about why the permissions need to be 700 and what specific issue this fixes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martimlobao martimlobao merged commit cf86fc8 into main Jan 21, 2025
9 checks passed
@martimlobao martimlobao deleted the fix/op-gh-fix branch January 21, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant