Fix panic when setting only_counter for default relabelings #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplicate labels used in `Collection.init()` in the same way as in `processSource`. Side-Effect: When overriding `method` one needs to manually add the split/whitelist config from `DefaultRelabelings` in their own config file. Resolve martin-helmich#216
martin-helmich
approved these changes
Oct 11, 2022
|
Code Climate has analyzed commit 7850511 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #216, adding relabel_configs for
statusormethod(own testing) withonly_counterwould cause a panic.The issue was, that the
Collectionstruct (and thus histograms) were set-up without deduplicating the labels first (or at least applying thecounterOnlyproperty to theDefaultRelabelings), thus the histograms were initialised with thecounterOnlylabels.I have opted against doing some sort of merging the defaults with user configuration. In part this is due to my absolute lack of knowledge of golang, but primarily since I didn't know how to differentiate user not setting values, e.g. whitelist, (=> apply defaults) or the user actively setting the defaults to revert back to them (=> do not apply defaults).
Resolve #216