sync with master #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change (with the acctest fix): ``` $ acctests azurerm TestAccAzureRMAutoScaleSetting_basic === RUN TestAccAzureRMAutoScaleSetting_basic --- FAIL: TestAccAzureRMAutoScaleSetting_basic (400.30s) testing.go:513: Step 0 error: Check failed: Check 7/7 error: azurerm_autoscale_setting.test: Attribute 'tags.$type' found when not expected FAIL FAIL github.com/terraform-providers/terraform-provider-azurerm/azurerm 400.721s ``` Now: ``` $ acctests azurerm TestAccAzureRMAutoScaleSetting_basic === RUN TestAccAzureRMAutoScaleSetting_basic --- PASS: TestAccAzureRMAutoScaleSetting_basic (399.98s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 400.321s ```
The options for `require_sni` were not indented/formatted consistently with the rest of the page
cleaning up some package tech debt
Fix some pointer references
Fix: Corrected regexp for eventhub name
martinbjorgan
pushed a commit
that referenced
this pull request
Jan 18, 2021
…rge-with-master Parse ID
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.