-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
86 application window #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to implement plugins and decorators that modify application behavior.
instead of Fn-traits, since they are easier to work with. Since closures have unique types, and function items are also special, they're not very easy to work with.
Currently the ECS doesn't run, only the window.
We should avoid automatic error conversions, so it's more clear.
Co-authored-by: Mathias Prétot <[email protected]>
martinjonsson01
requested review from
EdvinNilsson,
JacobBredin,
ChristofferPerssons and
linnosterlund
April 3, 2023 11:10
Benchmark for d49a9fcClick to view benchmark
|
EdvinNilsson
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
JacobBredin
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Cool Ideas used 👍
Co-authored-by: Edvin Nilsson <[email protected]>
Co-authored-by: Mathias Prétot <[email protected]>
…cs into 86-application-window
Benchmark for 76caa33Click to view benchmark
|
Benchmark for c21f5ccClick to view benchmark
|
Benchmark for a6c1767Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables rendering of an application window alongside the ECS running in the background. Part of this meant we had to generalize how plugins are added to the ECS engine.
The window is currently completely empty, as rendering of contents will be implemented in #87.
The new way of adding a plugin is:
(see
gfx-plugin\lib.rs
for a real example of this)and now this plugin can be enabled by calling:
Closes #86