Remove unnecessary mut reference. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyConfig::select() only creates a new HpkeConfig for matching suites; it doesn't need to modify any internal state.
martinthomson
approved these changes
Aug 3, 2022
|
Apparently clippy doesn't warn about this: rust-lang/rust-clippy#8863 🤷♂️ |
agokarn
pushed a commit
to microsoft/ohttp
that referenced
this pull request
Oct 29, 2024
* Support multiple key ID dynamically based on client request. Implement OHTTP configuration cache * Wait for receipt in OHTTP client * Add local keying mode for testing without KMS. Also added MAA token caching and optional MAA header in inference response * linter ifxes * fix * local testing * formatting * Add error handling changes again (martinthomson#24) * Add error handling changes again modified: Makefile modified: cgpuvm-attest/Cargo.toml modified: cgpuvm-attest/src/lib.rs modified: ohttp-client/src/main.rs modified: ohttp-server/src/main.rs modified: ohttp/src/err.rs Change logging Add logging Add logging * minor fixes * cleanup --------- Co-authored-by: Kapil Vaswani <[email protected]> * simplifcation * defaults --------- Co-authored-by: Antoine Delignat-Lavaud <[email protected]> Co-authored-by: agokarn <[email protected]> modified: ohttp/src/err.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyConfig::select() only creates a new HpkeConfig for matching
suites; it doesn't need to modify any internal state.