Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .desktop file. #138

Closed
Pival81 opened this issue Aug 9, 2016 · 15 comments
Closed

Missing .desktop file. #138

Pival81 opened this issue Aug 9, 2016 · 15 comments
Assignees

Comments

@Pival81
Copy link

Pival81 commented Aug 9, 2016

Hi, i tried to make a package for archlinux, it works (i basically put everything in /opt/museeks and made a symlink to /usr/bin) and i want to upload it on the aur, but a .desktop file to launch it from the desktop is missing, could you please provide it so i can make a proper package for the aur?

@martpie
Copy link
Owner

martpie commented Aug 9, 2016

Hey @Pival81 !

Should not be too hard, should it be placed at the root of the package ?

@Pival81
Copy link
Author

Pival81 commented Aug 9, 2016

What do you mean "root of the package"?

@martpie
Copy link
Owner

martpie commented Aug 9, 2016

I meant the root of the project. I'm not an expert in .desktop files, basically, it should look like this right ?

.desktop

#!/usr/bin/env xdg-open

[Desktop Entry]
Version=0.6.0
Name=Museeks
Comment=a free, lightweight and cross-platform music player
Exec=/opt/museeks/museeks
Icon=/opt/museeks/resources/app/src/images/logos/museeks.png
Terminal=false
Type=Application
Categories=Application;Music;Player;Audio;

@Pival81
Copy link
Author

Pival81 commented Aug 9, 2016

It's good (i think), i'll try it once i get home.
If it works, i add it to the package and upload it to the AUR.

@martpie
Copy link
Owner

martpie commented Aug 9, 2016

I'll add this file to the project soon.

edit: might need to edit how builds are done.

@Pival81
Copy link
Author

Pival81 commented Aug 9, 2016

Before you do the next release, i'll have to add it as a second file along with the main archive.

@martpie
Copy link
Owner

martpie commented Aug 9, 2016

Related issue #100 : create app installers

If you want to maintain Museeks on AUR, I can't give you any "official" support, that means you'll have to maintain the package manually for now.

Our short-term goal target is to package a .deb and a .tar.gz. Maintaining AUR or a PPA is not really whised. As I have no time for this, and there are important features to implement first.

@Pival81
Copy link
Author

Pival81 commented Aug 9, 2016

Of course, i'll care about the AUR package.

@martpie
Copy link
Owner

martpie commented Aug 10, 2016

Ok, so let's sum it up, the .desktop file must be at the root of the .tar.gz (in the same directory as the ./museeks excutable) right ?

  • Add a system in build.js to add some files at the root of the package depending of the targeted os

I'll give you a tar.gz archive so will be able to test it and tell me if everything's fine for you, ok ? Can you give me the exact bash instructions to install a tar.gz in the arch system ? (extraction + symlink if I get it well)

@martpie martpie self-assigned this Aug 10, 2016
@Pival81
Copy link
Author

Pival81 commented Aug 10, 2016

It's better if it's placed at the root of the archive, yes.
It should be:
tar -zxvf archive.tar.gz
cd archive (or whatever dir is extracted)
sudo cp -R * /opt/museeks
sudo ln -s /opt/museeks/museeks /usr/bin/museeks
sudo cp /opt/museeks/museeks.desktop /usr/share/applications/museeks.desktop

@Pival81
Copy link
Author

Pival81 commented Aug 10, 2016

But consider that the package is yet up and eunning on the AUR.
You just need to add the desktop file to the repo.
Now, i just noticed that another user made another package "museeks-bin", 3 hours before me.
It is essentially the same package, only the name changes.
And, that first line in the .desktop file (#!/usr/bin/env xdg-open) it's useless, you can delete it.

@martpie
Copy link
Owner

martpie commented Aug 10, 2016

Ok thanks for all the informations, I will push an update of the build script that automatically include a .desktop file for linux builds.

(poke #100)

@palob
Copy link

palob commented Aug 14, 2016

Please install the icon to a location compliant with freedesktop.org standards.

/usr/share/pixmaps
/usr/share/icons/hicolor/[size]/apps
~/.local/share/icons/hicolor/[size]/apps

You can change the icon line in the .desktop launcher to just Icon=museeks then.
Cf. this example .desktop launcher presented in the freedesktop.org documentation.

This allows for icon theming. Furthermore you can provide different icons in the various .../hicolor/[size] directories (in case you've got distinctly designed icons for different sizes).

The system will choose the appropriate size automatically.

@martpie martpie added this to the 1.0 milestone Sep 21, 2016
@martpie
Copy link
Owner

martpie commented Sep 21, 2016

Some news.

Installers are our main focus for 0.8. We will have to rewrite a part of our build system to integrate a .desktop, but this should come with the next release :)

@martpie martpie modified the milestones: 0.8, 1.0 Sep 21, 2016
@martpie martpie removed this from the 0.8 milestone Dec 1, 2016
@martpie
Copy link
Owner

martpie commented Feb 6, 2018

Shouldn't be needed anymore now .deb, snap and appimages are here.

@martpie martpie closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants