Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume bar opens to left of volume icon and covers the play buttons #351

Closed
giorgosioak opened this issue Jul 23, 2017 · 10 comments
Closed
Milestone

Comments

@giorgosioak
Copy link

giorgosioak commented Jul 23, 2017

The volume bar opens at the left of the volume icon and covers the play buttons until you move the mouse away. Sometimes you want to click pause you move your mouse over the volume icon and you need to make a second move to close the volume bar that pops up. Being on the right side of volume icon makes it more simple.

screenshot from 2017-07-23 13-20-02
screenshot from 2017-07-23 13-21-43

My suggestion is to make it open at the right of the icon 😉

Specs:
Museeks 0.8.1 (Installed via AUR) -- OS: Arch Linux -- Kernel: x86_64 Linux 4.11.7-1-ARCH

@martpie
Copy link
Owner

martpie commented Jul 25, 2017

Hello @giorgosioak, thanks for the suggestion and the usecase problem well detailed. I will try to find a nice solution to this problem :)

@martpie
Copy link
Owner

martpie commented Sep 8, 2017

Two quick mockups (poke @vprigent, @YurySolovyov). This is more what I had in mind. Just a few CSS tweaks.

screenshot from 2017-09-08 13 50 57

screenshot from 2017-09-08 13 51 41

personal preference for the first one, what do you think?

@vprigent Do you want to work on it?

@YurySolovyov
Copy link
Collaborator

Still 1 more interaction (click/hover) than needed.

@YurySolovyov
Copy link
Collaborator

YurySolovyov commented Sep 8, 2017

One possibility I see is to rework header in a way that will allow us to place volume control below or above the playback controls

@martpie
Copy link
Owner

martpie commented Sep 8, 2017

One requirement that I have is: "in a 1920*1080 screen, Museeks minimum width should not exceed half of the screen width".

Having a look at @giorgosioak problem, it's just he cannot adjust volume then directly click an play/pause. It's not really that he has to hover the volume to show VolumeControl. Or am I wrong?

@giorgosioak
Copy link
Author

@KeitIG Correct

@martpie
Copy link
Owner

martpie commented Apr 3, 2018

A bit unrelated, but it could be solved in the same issue. From #423 by @lottanbettan

a short delay (0.2 sec?) on hoover (volume button and timeline bar), would fix the "flickering" appearance.

@vprigent
Copy link
Contributor

vprigent commented Apr 3, 2018

Wow, I missed a lot of things here. A popup for the sound bar does not feel "good".
My PR is probably outdated and the solution was not ideal anyway.
#423 is more promising

@AntiGuide
Copy link

#509 seems like a good solution. Why isn't this getting merged?

@martpie
Copy link
Owner

martpie commented Dec 30, 2024

Fixed this way in the end image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants